diff options
| author | Julien Grall <julien.grall@citrix.com> | 2012-12-19 12:09:21 +0000 |
|---|---|---|
| committer | Andreas Färber <afaerber@suse.de> | 2013-01-15 19:45:25 +0100 |
| commit | ecd584b836937eb45f7e7e487595002486a09cb7 (patch) | |
| tree | a336308db12a651607b1aee059b564f83d8cf664 /cmd.c | |
| parent | cf7c3f0cb5a7129f57fa9e69d410d6a05031988c (diff) | |
| download | qemu-ecd584b836937eb45f7e7e487595002486a09cb7.zip qemu-ecd584b836937eb45f7e7e487595002486a09cb7.tar.gz qemu-ecd584b836937eb45f7e7e487595002486a09cb7.tar.bz2 | |
hw/dma.c: Fix conversion of ioport_register* to MemoryRegion
The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift for
some offset in DMA emulation.
Before the previous commit, which converted ioport_register_* to
MemoryRegion, the DMA controller registered 8 ioports with the following
formula:
base + ((8 + i) << d->shift) where 0 <= i < 8
When an IO occured within a Memory Region, DMA callback receives an
offset relative to the start address. Here the start address is:
base + (8 << d->shift).
The offset should be: (i << d->shift). After the shift is reverted, the
offsets are 0..7 not 1..8.
Fixes LP#1089996.
Reported-by: Andreas Gustafsson <gson@gson.org>
Signed-off-by: Julien Grall <julien.grall@citrix.com>
Tested-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Diffstat (limited to 'cmd.c')
0 files changed, 0 insertions, 0 deletions