diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2023-12-04 11:42:59 -0500 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-12-21 22:49:27 +0100 |
| commit | e661a2470342d6fa873369c81988a19b1bb7b3f4 (patch) | |
| tree | c77ddbbd38171b60c3b6fadebd9a5c6942b99f2f /bsd-user | |
| parent | 14042268045596a89f3fae3606389536d4784113 (diff) | |
| download | qemu-e661a2470342d6fa873369c81988a19b1bb7b3f4.zip qemu-e661a2470342d6fa873369c81988a19b1bb7b3f4.tar.gz qemu-e661a2470342d6fa873369c81988a19b1bb7b3f4.tar.bz2 | |
dma-helpers: don't lock AioContext in dma_blk_cb()
Commit abfcd2760b3e ("dma-helpers: prevent dma_blk_cb() vs
dma_aio_cancel() race") acquired the AioContext lock inside dma_blk_cb()
to avoid a race with scsi_device_purge_requests() running in the main
loop thread.
The SCSI code no longer calls dma_aio_cancel() from the main loop thread
while I/O is running in the IOThread AioContext. Therefore it is no
longer necessary to take this lock to protect DMAAIOCB fields. The
->cb() function also does not require the lock because blk_aio_*() and
friends do not need the AioContext lock.
Both hw/ide/core.c and hw/ide/macio.c also call dma_blk_io() but don't
rely on it taking the AioContext lock, so this change is safe.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231204164259.1515217-5-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'bsd-user')
0 files changed, 0 insertions, 0 deletions