diff options
| author | John Snow <jsnow@redhat.com> | 2019-07-29 16:35:55 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2019-08-16 16:28:03 -0400 |
| commit | a6c9365ad4ba26b274bb4b7491f99b05bb765d76 (patch) | |
| tree | 9124d66ca5d11621acd7edcb5dc9a1bdee5121e1 /blockdev.c | |
| parent | 0af2a09c6baac5c9ee93b6e78dcc6bb029361620 (diff) | |
| download | qemu-a6c9365ad4ba26b274bb4b7491f99b05bb765d76.zip qemu-a6c9365ad4ba26b274bb4b7491f99b05bb765d76.tar.gz qemu-a6c9365ad4ba26b274bb4b7491f99b05bb765d76.tar.bz2 | |
block/backup: hoist bitmap check into QMP interface
This is nicer to do in the unified QMP interface that we have now,
because it lets us use the right terminology back at the user.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Message-id: 20190716000117.25219-5-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'blockdev.c')
| -rw-r--r-- | blockdev.c | 10 |
1 files changed, 10 insertions, 0 deletions
@@ -3529,6 +3529,16 @@ static BlockJob *do_backup_common(BackupCommon *backup, return NULL; } + if ((backup->sync == MIRROR_SYNC_MODE_BITMAP) || + (backup->sync == MIRROR_SYNC_MODE_INCREMENTAL)) { + /* done before desugaring 'incremental' to print the right message */ + if (!backup->has_bitmap) { + error_setg(errp, "must provide a valid bitmap name for " + "'%s' sync mode", MirrorSyncMode_str(backup->sync)); + return NULL; + } + } + if (backup->sync == MIRROR_SYNC_MODE_INCREMENTAL) { if (backup->has_bitmap_mode && backup->bitmap_mode != BITMAP_SYNC_MODE_ON_SUCCESS) { |