diff options
author | Jeff Cody <jcody@redhat.com> | 2017-08-07 18:29:09 -0400 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2017-08-08 15:19:16 +0200 |
commit | 113fe792fd4931dd0538f03859278b8719ee4fa2 (patch) | |
tree | 48064249926a702c1d7181e1406957573215acb7 /blockdev-nbd.c | |
parent | ea22b7a2207721695342063175212c5be76d5c69 (diff) | |
download | qemu-113fe792fd4931dd0538f03859278b8719ee4fa2.zip qemu-113fe792fd4931dd0538f03859278b8719ee4fa2.tar.gz qemu-113fe792fd4931dd0538f03859278b8719ee4fa2.tar.bz2 |
block/nfs: fix mutex assertion in nfs_file_close()
Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion
checks for when qemu_mutex() functions are called without the
corresponding qemu_mutex_init() having initialized the mutex.
This uncovered a latent bug in qemu's nfs driver - in
nfs_client_close(), the NFSClient structure is overwritten with zeros,
prior to the mutex being destroyed.
Go ahead and destroy the mutex in nfs_client_close(), and change where
we call qemu_mutex_init() so that it is correctly balanced.
There are also a couple of memory leaks obscured by the memset, so this
fixes those as well.
Finally, we should be able to get rid of the memset(), as it isn't
necessary.
Cc: qemu-stable@nongnu.org
Signed-off-by: Jeff Cody <jcody@redhat.com>
Reviewed-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'blockdev-nbd.c')
0 files changed, 0 insertions, 0 deletions