diff options
| author | Max Reitz <mreitz@redhat.com> | 2015-10-19 17:53:11 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2015-10-23 18:18:22 +0200 |
| commit | e031f750483377a5e5de4c92af68dfa68e4d0aae (patch) | |
| tree | 06482e05eac9020623c7ba715110bb6b9dacad2d /block | |
| parent | 8e9e653038db97bfd343c3fb217b7bf4da765a89 (diff) | |
| download | qemu-e031f750483377a5e5de4c92af68dfa68e4d0aae.zip qemu-e031f750483377a5e5de4c92af68dfa68e4d0aae.tar.gz qemu-e031f750483377a5e5de4c92af68dfa68e4d0aae.tar.bz2 | |
block: Make bdrv_is_inserted() return a bool
Make bdrv_is_inserted(), blk_is_inserted(), and the callback
BlockDriver.bdrv_is_inserted() return a bool.
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/block-backend.c | 2 | ||||
| -rw-r--r-- | block/raw-posix.c | 8 | ||||
| -rw-r--r-- | block/raw_bsd.c | 2 |
3 files changed, 5 insertions, 7 deletions
diff --git a/block/block-backend.c b/block/block-backend.c index 2256551..1db002c 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -769,7 +769,7 @@ void blk_invalidate_cache(BlockBackend *blk, Error **errp) bdrv_invalidate_cache(blk->bs, errp); } -int blk_is_inserted(BlockBackend *blk) +bool blk_is_inserted(BlockBackend *blk) { return bdrv_is_inserted(blk->bs); } diff --git a/block/raw-posix.c b/block/raw-posix.c index 2e3db44..918c756 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -2398,15 +2398,13 @@ out: return prio; } -static int cdrom_is_inserted(BlockDriverState *bs) +static bool cdrom_is_inserted(BlockDriverState *bs) { BDRVRawState *s = bs->opaque; int ret; ret = ioctl(s->fd, CDROM_DRIVE_STATUS, CDSL_CURRENT); - if (ret == CDS_DISC_OK) - return 1; - return 0; + return ret == CDS_DISC_OK; } static void cdrom_eject(BlockDriverState *bs, bool eject_flag) @@ -2532,7 +2530,7 @@ static int cdrom_reopen(BlockDriverState *bs) return 0; } -static int cdrom_is_inserted(BlockDriverState *bs) +static bool cdrom_is_inserted(BlockDriverState *bs) { return raw_getlength(bs) > 0; } diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 63ee911..3c7b413 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -154,7 +154,7 @@ static int raw_truncate(BlockDriverState *bs, int64_t offset) return bdrv_truncate(bs->file->bs, offset); } -static int raw_is_inserted(BlockDriverState *bs) +static bool raw_is_inserted(BlockDriverState *bs) { return bdrv_is_inserted(bs->file->bs); } |