diff options
| author | Max Reitz <mreitz@redhat.com> | 2019-07-24 19:12:33 +0200 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2019-08-19 17:13:26 +0200 |
| commit | b647d69adc394312dedb56f6b3ce19b9c316931f (patch) | |
| tree | e5ee4fcdee9d037b303b5e74dba6363aed7da484 /block | |
| parent | 1dcaf52760ccaa2e019164c887b8436ac6c5d8ea (diff) | |
| download | qemu-b647d69adc394312dedb56f6b3ce19b9c316931f.zip qemu-b647d69adc394312dedb56f6b3ce19b9c316931f.tar.gz qemu-b647d69adc394312dedb56f6b3ce19b9c316931f.tar.bz2 | |
block: Use bdrv_has_zero_init_truncate()
vhdx and parallels call bdrv_has_zero_init() when they do not really
care about an image's post-create state but only about what happens when
you grow an image. That is a bit ugly, and also overly safe when
growing preallocated images without preallocating the new areas.
Let them use bdrv_has_zero_init_truncate() instead.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-id: 20190724171239.8764-6-mreitz@redhat.com
Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
[mreitz: Added commit message]
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/parallels.c | 2 | ||||
| -rw-r--r-- | block/vhdx.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/block/parallels.c b/block/parallels.c index 00fae12..7cd2714 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -835,7 +835,7 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags, goto fail_options; } - if (!bdrv_has_zero_init(bs->file->bs)) { + if (!bdrv_has_zero_init_truncate(bs->file->bs)) { s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE; } diff --git a/block/vhdx.c b/block/vhdx.c index d6070b6..a02d1c9 100644 --- a/block/vhdx.c +++ b/block/vhdx.c @@ -1282,7 +1282,7 @@ static coroutine_fn int vhdx_co_writev(BlockDriverState *bs, int64_t sector_num, /* Queue another write of zero buffers if the underlying file * does not zero-fill on file extension */ - if (bdrv_has_zero_init(bs->file->bs) == 0) { + if (bdrv_has_zero_init_truncate(bs->file->bs) == 0) { use_zero_buffers = true; /* zero fill the front, if any */ |