diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-11-15 18:20:11 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-11-21 12:45:21 +0100 |
| commit | 1dbc7d344246e1c8000825bee220e4c2767ba765 (patch) | |
| tree | 69ad6b8858b175da248e766ec38d38a33a9c58b5 /block | |
| parent | 6bc0bcc89f847839cf3d459a55290dda8801d9d3 (diff) | |
| download | qemu-1dbc7d344246e1c8000825bee220e4c2767ba765.zip qemu-1dbc7d344246e1c8000825bee220e4c2767ba765.tar.gz qemu-1dbc7d344246e1c8000825bee220e4c2767ba765.tar.bz2 | |
stream: Fix AioContext locking during bdrv_graph_wrlock()
In stream_prepare(), we need to temporarily drop the AioContext lock
that job_prepare_locked() took for us while calling the graph write lock
functions which can poll.
All block nodes related to this block job are in the same AioContext, so
we can pass any of them to bdrv_graph_wrlock()/ bdrv_graph_wrunlock().
Unfortunately, the one that we picked is base, which can be NULL - and
in this case the AioContext lock is not released and deadlocks can
occur.
Fix this by passing s->target_bs, which is never NULL.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231115172012.112727-4-kwolf@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block')
| -rw-r--r-- | block/stream.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/block/stream.c b/block/stream.c index e3aa696..01fe7c0 100644 --- a/block/stream.c +++ b/block/stream.c @@ -99,9 +99,9 @@ static int stream_prepare(Job *job) } } - bdrv_graph_wrlock(base); + bdrv_graph_wrlock(s->target_bs); bdrv_set_backing_hd_drained(unfiltered_bs, base, &local_err); - bdrv_graph_wrunlock(base); + bdrv_graph_wrunlock(s->target_bs); /* * This call will do I/O, so the graph can change again from here on. |