aboutsummaryrefslogtreecommitdiff
path: root/block/vmdk.c
diff options
context:
space:
mode:
authoryuchenlin <yuchenlin@synology.com>2018-03-22 21:33:37 +0800
committerMax Reitz <mreitz@redhat.com>2018-03-26 21:17:24 +0200
commita77672ea3d95094a0cb4f974de84fb7353c67cc0 (patch)
tree095141018fec5e013b8cf9e5729cb295ed55c8a3 /block/vmdk.c
parentf7640f0dbc7becbd0927dd3fcf65cdf5a55adf89 (diff)
downloadqemu-a77672ea3d95094a0cb4f974de84fb7353c67cc0.zip
qemu-a77672ea3d95094a0cb4f974de84fb7353c67cc0.tar.gz
qemu-a77672ea3d95094a0cb4f974de84fb7353c67cc0.tar.bz2
vmdk: return ERROR when cluster sector is larger than vmdk limitation
VMDK has a hard limitation of extent size, which is due to the size of grain table entry is 32 bits. It means it can only point to a grain located at offset = 2^32. To avoid writing the user data beyond limitation and record a useless offset in grain table. We should return ERROR here. Signed-off-by: yuchenlin <yuchenlin@synology.com> Message-id: 20180322133337.28024-1-yuchenlin@synology.com Reviewed-by: Fam Zheng <famz@redhat.com> Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/vmdk.c')
-rw-r--r--block/vmdk.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/block/vmdk.c b/block/vmdk.c
index f94c49a..84f8bbe 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -47,6 +47,8 @@
#define VMDK4_FLAG_MARKER (1 << 17)
#define VMDK4_GD_AT_END 0xffffffffffffffffULL
+#define VMDK_EXTENT_MAX_SECTORS (1ULL << 32)
+
#define VMDK_GTE_ZEROED 0x1
/* VMDK internal error codes */
@@ -1250,6 +1252,10 @@ static int get_cluster_offset(BlockDriverState *bs,
return zeroed ? VMDK_ZEROED : VMDK_UNALLOC;
}
+ if (extent->next_cluster_sector >= VMDK_EXTENT_MAX_SECTORS) {
+ return VMDK_ERROR;
+ }
+
cluster_sector = extent->next_cluster_sector;
extent->next_cluster_sector += extent->cluster_sectors;