aboutsummaryrefslogtreecommitdiff
path: root/block/stream.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2016-04-18 15:14:11 +0200
committerKevin Wolf <kwolf@redhat.com>2016-05-19 16:45:31 +0200
commit66a0fae438d2888f3b06cd7bd2795bb226956c05 (patch)
treeff7bc074102cd359c9e2215637827dc99605aa17 /block/stream.c
parent81e254dc8349795d17c585a997f9076b77a863fc (diff)
downloadqemu-66a0fae438d2888f3b06cd7bd2795bb226956c05.zip
qemu-66a0fae438d2888f3b06cd7bd2795bb226956c05.tar.gz
qemu-66a0fae438d2888f3b06cd7bd2795bb226956c05.tar.bz2
blockjob: Don't touch BDS iostatus
Block jobs don't actually make use of the iostatus for their BDSes, but they manage a separate block job iostatus. Still, they require that it is enabled for the source BDS and they enable it automatically for the target and set the error handling mode - which ends up never being used by the job. This patch removes all of the BDS iostatus handling from the block job, which removes another few bs->blk accesses. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/stream.c')
-rw-r--r--block/stream.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/block/stream.c b/block/stream.c
index 16c3e90..40aa322 100644
--- a/block/stream.c
+++ b/block/stream.c
@@ -223,13 +223,6 @@ void stream_start(BlockDriverState *bs, BlockDriverState *base,
{
StreamBlockJob *s;
- if ((on_error == BLOCKDEV_ON_ERROR_STOP ||
- on_error == BLOCKDEV_ON_ERROR_ENOSPC) &&
- (!bs->blk || !blk_iostatus_is_enabled(bs->blk))) {
- error_setg(errp, QERR_INVALID_PARAMETER, "on-error");
- return;
- }
-
s = block_job_create(&stream_job_driver, bs, speed, cb, opaque, errp);
if (!s) {
return;