diff options
| author | Alberto Garcia <berto@igalia.com> | 2020-09-03 18:37:48 +0200 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2020-09-15 11:05:13 +0200 |
| commit | f7bd5bba1b8ce7200600bacee024bce525083f60 (patch) | |
| tree | ab7492da4c45be407d0f1947ffdc45b5880af29e /block/qcow2.c | |
| parent | 184581fa4d8a83c601d967971f8460faeeb742ac (diff) | |
| download | qemu-f7bd5bba1b8ce7200600bacee024bce525083f60.zip qemu-f7bd5bba1b8ce7200600bacee024bce525083f60.tar.gz qemu-f7bd5bba1b8ce7200600bacee024bce525083f60.tar.bz2 | |
qcow2: Don't check nb_clusters when removing l2meta from the list
In the past, when a new cluster was allocated the l2meta structure was
a variable in the stack so it was necessary to have a way to tell
whether it had been initialized and contained valid data or not. The
nb_clusters field was used for this purpose. Since commit f50f88b9fe
this is no longer the case, l2meta (nowadays a pointer to a list) is
only allocated when needed and nb_clusters is guaranteed to be > 0 so
this check is unnecessary.
Signed-off-by: Alberto Garcia <berto@igalia.com>
Message-Id: <ab0b67c29c7ba26e598db35f12aa5ab5982539c1.1599150873.git.berto@igalia.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'block/qcow2.c')
| -rw-r--r-- | block/qcow2.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/block/qcow2.c b/block/qcow2.c index ef9a45e..3e8114d 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2111,9 +2111,7 @@ static coroutine_fn int qcow2_handle_l2meta(BlockDriverState *bs, } /* Take the request off the list of running requests */ - if (l2meta->nb_clusters != 0) { - QLIST_REMOVE(l2meta, next_in_flight); - } + QLIST_REMOVE(l2meta, next_in_flight); qemu_co_queue_restart_all(&l2meta->dependent_requests); |