aboutsummaryrefslogtreecommitdiff
path: root/block/mirror.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2018-03-22 10:57:14 +0100
committerKevin Wolf <kwolf@redhat.com>2018-06-18 15:03:25 +0200
commit1cc8e54ada97f7ac479554e15ca9e426c895b158 (patch)
treebaea764fbca6465c70de628a2c9c5080f0f42ef9 /block/mirror.c
parent6d0252f2f9cb49925deb1c41101462c9481dfc90 (diff)
downloadqemu-1cc8e54ada97f7ac479554e15ca9e426c895b158.zip
qemu-1cc8e54ada97f7ac479554e15ca9e426c895b158.tar.gz
qemu-1cc8e54ada97f7ac479554e15ca9e426c895b158.tar.bz2
block: Avoid unnecessary aio_poll() in AIO_WAIT_WHILE()
Commit 91af091f923 added an additional aio_poll() to BDRV_POLL_WHILE() in order to make sure that all pending BHs are executed on drain. This was the wrong place to make the fix, as it is useless overhead for all other users of the macro and unnecessarily complicates the mechanism. This patch effectively reverts said commit (the context has changed a bit and the code has moved to AIO_WAIT_WHILE()) and instead polls in the loop condition for drain. The effect is probably hard to measure in any real-world use case because actual I/O will dominate, but if I run only the initialisation part of 'qemu-img convert' where it calls bdrv_block_status() for the whole image to find out how much data there is copy, this phase actually needs only roughly half the time after this patch. Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'block/mirror.c')
0 files changed, 0 insertions, 0 deletions