aboutsummaryrefslogtreecommitdiff
path: root/block/commit.c
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2017-05-08 16:13:02 +0200
committerJeff Cody <jcody@redhat.com>2017-05-24 16:38:51 -0400
commit05b0d8e3b8a1ed1a5840a317ce4f7f4ebe53156f (patch)
tree94487e194c1c0e31d8035e25b2e598f323e521b8 /block/commit.c
parent9f086abbe43d29de2409e01d8fb2d68a6102afbc (diff)
downloadqemu-05b0d8e3b8a1ed1a5840a317ce4f7f4ebe53156f.zip
qemu-05b0d8e3b8a1ed1a5840a317ce4f7f4ebe53156f.tar.gz
qemu-05b0d8e3b8a1ed1a5840a317ce4f7f4ebe53156f.tar.bz2
blockjob: introduce block_job_early_fail
Outside blockjob.c, block_job_unref is only used when a block job fails to start, and block_job_ref is not used at all. The reference counting thus is pretty well hidden. Introduce a separate function to be used by block jobs; because block_job_ref and block_job_unref now become static, move them earlier in blockjob.c. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: John Snow <jsnow@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Jeff Cody <jcody@redhat.com> Message-id: 20170508141310.8674-4-pbonzini@redhat.com Signed-off-by: Jeff Cody <jcody@redhat.com>
Diffstat (limited to 'block/commit.c')
-rw-r--r--block/commit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/commit.c b/block/commit.c
index 76a0d98..a3028b2 100644
--- a/block/commit.c
+++ b/block/commit.c
@@ -426,7 +426,7 @@ fail:
if (commit_top_bs) {
bdrv_set_backing_hd(overlay_bs, top, &error_abort);
}
- block_job_unref(&s->common);
+ block_job_early_fail(&s->common);
}