diff options
author | Kevin Wolf <kwolf@redhat.com> | 2023-10-27 17:53:18 +0200 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2023-11-07 19:14:19 +0100 |
commit | 9275fc72bd0a1c35e915e4991c7d27209ecab923 (patch) | |
tree | 36e8c741bc89c5db065e8c91dc11b4a7a6fd9136 /block.c | |
parent | ad74751fc0ffdad7678224df0e752689ebb3f4b7 (diff) | |
download | qemu-9275fc72bd0a1c35e915e4991c7d27209ecab923.zip qemu-9275fc72bd0a1c35e915e4991c7d27209ecab923.tar.gz qemu-9275fc72bd0a1c35e915e4991c7d27209ecab923.tar.bz2 |
block: Mark bdrv_(un)freeze_backing_chain() and callers GRAPH_RDLOCK
This adds GRAPH_RDLOCK annotations to declare that callers of
bdrv_(un)freeze_backing_chain() need to hold a reader lock for the
graph because it calls bdrv_filter_or_cow_child(), which accesses
bs->file/backing.
Use the opportunity to make bdrv_is_backing_chain_frozen() static, it
has no external callers.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231027155333.420094-10-kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r-- | block.c | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -5843,8 +5843,9 @@ BlockDriverState *bdrv_find_base(BlockDriverState *bs) * between @bs and @base is frozen. @errp is set if that's the case. * @base must be reachable from @bs, or NULL. */ -bool bdrv_is_backing_chain_frozen(BlockDriverState *bs, BlockDriverState *base, - Error **errp) +static bool GRAPH_RDLOCK +bdrv_is_backing_chain_frozen(BlockDriverState *bs, BlockDriverState *base, + Error **errp) { BlockDriverState *i; BdrvChild *child; |