diff options
| author | Steve Sistare <steven.sistare@oracle.com> | 2024-01-03 12:05:36 -0800 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-01-04 09:52:42 +0800 |
| commit | 58b105703e86c1721d1a4cb9f6aaaca49c82145e (patch) | |
| tree | bec29b151173d3da31d731a9d6a6dfe6cad6c97f /block.c | |
| parent | b4e9ddccd1a64239c07d7229afd7e00eed5afcd8 (diff) | |
| download | qemu-58b105703e86c1721d1a4cb9f6aaaca49c82145e.zip qemu-58b105703e86c1721d1a4cb9f6aaaca49c82145e.tar.gz qemu-58b105703e86c1721d1a4cb9f6aaaca49c82145e.tar.bz2 | |
migration: preserve suspended for snapshot
Restoring a snapshot can break a suspended guest. Snapshots suffer from
the same suspended-state issues that affect live migration, plus they must
handle an additional problematic scenario, which is that a running vm must
remain running if it loads a suspended snapshot.
To save, the existing vm_stop call now completely stops the suspended
state. Finish with vm_resume to leave the vm in the state it had prior
to the save, correctly restoring the suspended state.
To load, if the snapshot is not suspended, then vm_stop + vm_resume
correctly handles all states, and leaves the vm in the state it had prior
to the load. However, if the snapshot is suspended, restoration is
trickier. First, call vm_resume to restore the state to suspended so the
current state matches the saved state. Then, if the pre-load state is
running, call wakeup to resume running.
Prior to these changes, the vm_stop to RUN_STATE_SAVE_VM and
RUN_STATE_RESTORE_VM did not change runstate if the current state was
suspended, but now it does, so allow these transitions.
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/1704312341-66640-8-git-send-email-steven.sistare@oracle.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'block.c')
0 files changed, 0 insertions, 0 deletions