diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2023-09-11 11:46:15 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-09-20 17:46:01 +0200 |
| commit | 356f4ef611df18f6f8323a9fe6e6b4963272bf74 (patch) | |
| tree | b828ed64efd6a6c1ec9126c44c07ed17d3a62489 /block.c | |
| parent | c629b6d22349c83ca262d1887c0920e87ec0bfdb (diff) | |
| download | qemu-356f4ef611df18f6f8323a9fe6e6b4963272bf74.zip qemu-356f4ef611df18f6f8323a9fe6e6b4963272bf74.tar.gz qemu-356f4ef611df18f6f8323a9fe6e6b4963272bf74.tar.bz2 | |
block: Mark bdrv_parent_cb_change_media() GRAPH_RDLOCK
The function reads the parents list, so it needs to hold the graph lock.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230911094620.45040-17-kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
| -rw-r--r-- | block.c | 6 |
1 files changed, 5 insertions, 1 deletions
@@ -3371,7 +3371,8 @@ void bdrv_unref_child(BlockDriverState *parent, BdrvChild *child) } -static void bdrv_parent_cb_change_media(BlockDriverState *bs, bool load) +static void GRAPH_RDLOCK +bdrv_parent_cb_change_media(BlockDriverState *bs, bool load) { BdrvChild *c; GLOBAL_STATE_CODE(); @@ -3969,6 +3970,9 @@ bdrv_open_inherit(const char *filename, const char *reference, QDict *options, GLOBAL_STATE_CODE(); assert(!qemu_in_coroutine()); + /* TODO We'll eventually have to take a writer lock in this function */ + GRAPH_RDLOCK_GUARD_MAINLOOP(); + if (reference) { bool options_non_empty = options ? qdict_size(options) : false; qobject_unref(options); |