aboutsummaryrefslogtreecommitdiff
path: root/block.c
diff options
context:
space:
mode:
authorKevin Wolf <kwolf@redhat.com>2019-03-11 16:13:16 +0100
committerKevin Wolf <kwolf@redhat.com>2019-03-12 20:30:14 +0100
commit30855137783c0c762007044821a6f11e14e6af33 (patch)
treed30b921270e23e1d0852e0c18533c7967be4add6 /block.c
parent69b736e76567ecbc9b9e55570bc0afc840614a98 (diff)
downloadqemu-30855137783c0c762007044821a6f11e14e6af33.zip
qemu-30855137783c0c762007044821a6f11e14e6af33.tar.gz
qemu-30855137783c0c762007044821a6f11e14e6af33.tar.bz2
file-posix: Fix bdrv_open_flags() for snapshot=on
Using a different read-only setting for bs->open_flags than for the flags to the driver's open function is just inconsistent and a bad idea. After this patch, the temporary snapshot keeps being opened read-only if read-only=on,snapshot=on is passed. If we wanted to change this behaviour to make only the orginal image file read-only, but the temporary overlay read-write (as the comment in the removed code suggests), that change would have to be made in bdrv_temp_snapshot_options() (where the comment suggests otherwise). Addressing this inconsistency before introducing dynamic auto-read-only is important because otherwise we would immediately try to reopen the temporary overlay even though the file is already unlinked. Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'block.c')
-rw-r--r--block.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/block.c b/block.c
index 9b9d25e..33804cd 100644
--- a/block.c
+++ b/block.c
@@ -1163,13 +1163,6 @@ static int bdrv_open_flags(BlockDriverState *bs, int flags)
*/
open_flags &= ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING | BDRV_O_PROTOCOL);
- /*
- * Snapshots should be writable.
- */
- if (flags & BDRV_O_TEMPORARY) {
- open_flags |= BDRV_O_RDWR;
- }
-
return open_flags;
}