diff options
author | Max Reitz <mreitz@redhat.com> | 2021-02-19 16:33:47 +0100 |
---|---|---|
committer | Kevin Wolf <kwolf@redhat.com> | 2021-03-08 14:55:18 +0100 |
commit | 705dde27c6c53b73d2aa139b5b2a0ea490153e5b (patch) | |
tree | 8c8115d08239512606b60bea463ad061429299f6 /backends | |
parent | bdc4c4c5e372756a5ba3fb3a61e585b02f0dd7f4 (diff) | |
download | qemu-705dde27c6c53b73d2aa139b5b2a0ea490153e5b.zip qemu-705dde27c6c53b73d2aa139b5b2a0ea490153e5b.tar.gz qemu-705dde27c6c53b73d2aa139b5b2a0ea490153e5b.tar.bz2 |
backup-top: Refuse I/O in inactive state
When the backup-top node transitions from active to inactive in
bdrv_backup_top_drop(), the BlockCopyState is freed and the filtered
child is removed, so the node effectively becomes unusable.
However, noone told its I/O functions this, so they will happily
continue accessing bs->backing and s->bcs. Prevent that by aborting
early when s->active is false.
(After the preceding patch, the node should be gone after
bdrv_backup_top_drop(), so this should largely be a theoretical problem.
But still, better to be safe than sorry, and also I think it just makes
sense to check s->active in the I/O functions.)
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210219153348.41861-3-mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'backends')
0 files changed, 0 insertions, 0 deletions