aboutsummaryrefslogtreecommitdiff
path: root/accel
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2022-11-17 11:55:52 -0500
committerStefan Hajnoczi <stefanha@redhat.com>2022-11-21 09:28:43 -0500
commitbd142b2391a4369f39f9f4e8c48b15ed18280446 (patch)
tree7a456ee698a72af92f33a125eb6b1eb6d6c6fb78 /accel
parent0b710ae5c5d6386ec2cab89aad06067b167e263e (diff)
downloadqemu-bd142b2391a4369f39f9f4e8c48b15ed18280446.zip
qemu-bd142b2391a4369f39f9f4e8c48b15ed18280446.tar.gz
qemu-bd142b2391a4369f39f9f4e8c48b15ed18280446.tar.bz2
rtl8139: avoid clobbering tx descriptor bits
The device turns the Tx Descriptor into a Tx Status descriptor after fully reading the descriptor. This involves clearing Tx Own (bit 31) to indicate that the driver has ownership of the descriptor again as well as several other bits. The code keeps the first dword of the Tx Descriptor in the txdw0 local variable. txdw0 is reused to build the first word of the Tx Status descriptor. Later on the code uses txdw0 again, incorrectly assuming that it still contains the first dword of the Tx Descriptor. The tx offloading code misbehaves because it sees bogus bits in txdw0. Use a separate local variable for Tx Status and preserve Tx Descriptor in txdw0. Acked-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20221117165554.1773409-2-stefanha@redhat.com>
Diffstat (limited to 'accel')
0 files changed, 0 insertions, 0 deletions