aboutsummaryrefslogtreecommitdiff
path: root/accel
diff options
context:
space:
mode:
authorDaniel P. Berrangé <berrange@redhat.com>2024-07-12 14:24:52 +0100
committerKonstantin Kostiuk <kkostiuk@redhat.com>2024-07-19 11:50:35 +0300
commitadbe794a6ef7e8c52cec2dc3c8685f1a96507f24 (patch)
treeb67d9a700ac2ae5d50ef87e8e4436669ab512c3b /accel
parent21ca6854d8ef8020d605433773fceeecd10b11fd (diff)
downloadqemu-adbe794a6ef7e8c52cec2dc3c8685f1a96507f24.zip
qemu-adbe794a6ef7e8c52cec2dc3c8685f1a96507f24.tar.gz
qemu-adbe794a6ef7e8c52cec2dc3c8685f1a96507f24.tar.bz2
qga: conditionalize schema for commands requiring libudev
Rather than creating stubs for every command that just return QERR_UNSUPPORTED, use 'if' conditions in the schema to fully exclude generation of the filesystem trimming commands on POSIX platforms lacking required APIs. The command will be rejected at QMP dispatch time instead, avoiding reimplementing rejection by blocking the stub commands. This changes the error message for affected commands from {"class": "CommandNotFound", "desc": "Command FOO has been disabled"} to {"class": "CommandNotFound", "desc": "The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org> Message-ID: <20240712132459.3974109-16-berrange@redhat.com> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Diffstat (limited to 'accel')
0 files changed, 0 insertions, 0 deletions