aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <philmd@linaro.org>2023-10-09 10:21:22 +0200
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2023-10-20 14:46:06 +0200
commitfaf026b2a22da1044baf7f1f3ab1280b2a448399 (patch)
tree1878151159f36b8466fb07e7477fa4a427c50a01
parentae5f70baf549925080fcdbc6c1939c98a4a39246 (diff)
downloadqemu-faf026b2a22da1044baf7f1f3ab1280b2a448399.zip
qemu-faf026b2a22da1044baf7f1f3ab1280b2a448399.tar.gz
qemu-faf026b2a22da1044baf7f1f3ab1280b2a448399.tar.bz2
hw/mips/malta: Use sdram_type enum from 'hw/i2c/smbus_eeprom.h'
Since commit 93198b6cad ("i2c: Split smbus into parts") the SDRAM types are enumerated as sdram_type in "hw/i2c/smbus_eeprom.h". Using the enum removes this global shadow warning: hw/mips/malta.c:209:12: error: declaration shadows a variable in the global scope [-Werror,-Wshadow] enum { SDR = 0x4, DDR2 = 0x8 } type; ^ include/hw/i2c/smbus_eeprom.h:33:19: note: previous declaration is here enum sdram_type { SDR = 0x4, DDR = 0x7, DDR2 = 0x8 }; ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20231009092127.49778-1-philmd@linaro.org>
-rw-r--r--hw/mips/malta.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/mips/malta.c b/hw/mips/malta.c
index dac27fa..62d04ed 100644
--- a/hw/mips/malta.c
+++ b/hw/mips/malta.c
@@ -206,7 +206,7 @@ static eeprom24c0x_t spd_eeprom = {
static void generate_eeprom_spd(uint8_t *eeprom, ram_addr_t ram_size)
{
- enum { SDR = 0x4, DDR2 = 0x8 } type;
+ enum sdram_type type;
uint8_t *spd = spd_eeprom.contents;
uint8_t nbanks = 0;
uint16_t density = 0;