diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2025-08-19 17:02:35 +0200 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2025-08-19 14:05:56 -0400 |
| commit | faaaf017d5b9c9f84fb86dcee016944176eee0d9 (patch) | |
| tree | a4debb5936ebef8cd2d6270fd9f88e4b5baf384e | |
| parent | 5836af0783213b9355a6bbf85d9e6bc4c9c9363f (diff) | |
| download | qemu-faaaf017d5b9c9f84fb86dcee016944176eee0d9.zip qemu-faaaf017d5b9c9f84fb86dcee016944176eee0d9.tar.gz qemu-faaaf017d5b9c9f84fb86dcee016944176eee0d9.tar.bz2 | |
Revert "i386/cpu: Warn about why CPUID_EXT_PDCM is not available"
This reverts commit 00268e00027459abede448662f8794d78eb4b0a4.
(The only conflict is in the !is_tdx_vm() part of the condition,
which is safe to keep).
mark_unavailable_features() actively blocks usage of the feature,
so it is a functional change, not merely a emitting warning.
The commit was intended to merely warn if PDCM was enabled when
the performance counters are not, so revert it.
Reported-by: Christian A. Ehrhardt <christian.ehrhardt@canonical.com>
Analyzed-by: Daniel P. Berrangé <berrange@redhat.com>
Analyzed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-ID: <20250819150235.785559-1-pbonzini@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | target/i386/cpu.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 673f858..6d85149 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -8946,9 +8946,6 @@ void x86_cpu_expand_features(X86CPU *cpu, Error **errp) /* PDCM is fixed1 bit for TDX */ if (!cpu->enable_pmu && !is_tdx_vm()) { - mark_unavailable_features(cpu, FEAT_1_ECX, - env->user_features[FEAT_1_ECX] & CPUID_EXT_PDCM, - "This feature is not available due to PMU being disabled"); env->features[FEAT_1_ECX] &= ~CPUID_EXT_PDCM; } |