aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Cave-Ayland <mark.cave-ayland@ilande.co.uk>2024-06-06 10:53:16 +0100
committerPaolo Bonzini <pbonzini@redhat.com>2024-06-08 10:33:38 +0200
commitf41990f552839ad016467586a9540b9455cc52fd (patch)
treeffe136f1ce5147a77cc0c039d0b4a23f2ef2d665
parentb37c0dc85214e9d5e4a9b6f6a496ce4de3b8a4d6 (diff)
downloadqemu-f41990f552839ad016467586a9540b9455cc52fd.zip
qemu-f41990f552839ad016467586a9540b9455cc52fd.tar.gz
qemu-f41990f552839ad016467586a9540b9455cc52fd.tar.bz2
target/i386: use local X86DecodedOp in gen_POP()
This will make subsequent changes a little easier to read. Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Message-ID: <20240606095319.229650-2-mark.cave-ayland@ilande.co.uk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
-rw-r--r--target/i386/tcg/emit.c.inc6
1 files changed, 4 insertions, 2 deletions
diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc
index f90f3d3..ca78504 100644
--- a/target/i386/tcg/emit.c.inc
+++ b/target/i386/tcg/emit.c.inc
@@ -2575,11 +2575,13 @@ static void gen_PMOVMSKB(DisasContext *s, CPUX86State *env, X86DecodedInsn *deco
static void gen_POP(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode)
{
+ X86DecodedOp *op = &decode->op[0];
MemOp ot = gen_pop_T0(s);
- if (decode->op[0].has_ea) {
+
+ if (op->has_ea) {
/* NOTE: order is important for MMU exceptions */
gen_op_st_v(s, ot, s->T0, s->A0);
- decode->op[0].unit = X86_OP_SKIP;
+ op->unit = X86_OP_SKIP;
}
/* NOTE: writing back registers after update is important for pop %sp */
gen_pop_update(s, ot);