diff options
| author | Paolo Bonzini <pbonzini@redhat.com> | 2025-07-17 12:32:23 +0200 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2025-07-17 17:18:59 +0200 |
| commit | f2b787976342a9e1d47810f3146ad74b86a5088a (patch) | |
| tree | 50511c851089fa8581d6095415952afa0d9ffbcc | |
| parent | e00cb2189a920bcfb428622c5d112469c4a094d1 (diff) | |
| download | qemu-f2b787976342a9e1d47810f3146ad74b86a5088a.zip qemu-f2b787976342a9e1d47810f3146ad74b86a5088a.tar.gz qemu-f2b787976342a9e1d47810f3146ad74b86a5088a.tar.bz2 | |
target/i386: tdx: fix locking for interrupt injection
Take tdx_guest->lock when injecting the event notification interrupt into
the guest.
Fixes CID 1612364.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Cc: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | target/i386/kvm/tdx.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 7d69d6d..1574e7d 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1126,10 +1126,15 @@ int tdx_parse_tdvf(void *flash_ptr, int size) return tdvf_parse_metadata(&tdx_guest->tdvf, flash_ptr, size); } -static void tdx_inject_interrupt(uint32_t apicid, uint32_t vector) +static void tdx_inject_interrupt(TdxGuest *tdx) { int ret; + uint32_t apicid, vector; + qemu_mutex_lock(&tdx->lock); + vector = tdx->event_notify_vector; + apicid = tdx->event_notify_apicid; + qemu_mutex_unlock(&tdx->lock); if (vector < 32 || vector > 255) { return; } @@ -1179,8 +1184,7 @@ static void tdx_get_quote_completion(TdxGenerateQuoteTask *task) error_report("TDX: get-quote: failed to update GetQuote header."); } - tdx_inject_interrupt(tdx_guest->event_notify_apicid, - tdx_guest->event_notify_vector); + tdx_inject_interrupt(tdx); g_free(task->send_data); g_free(task->receive_buf); |