diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-02-28 09:17:40 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-03-09 18:51:45 +0100 |
| commit | ecca5ca549c13202504aacaf2885ccbed4c021e7 (patch) | |
| tree | 763f7d80f427d9f609c43f838b47a89bc661c83e | |
| parent | 3ac5f6725a2158958afaf686d7a1ed3c7fbe0b12 (diff) | |
| download | qemu-ecca5ca549c13202504aacaf2885ccbed4c021e7.zip qemu-ecca5ca549c13202504aacaf2885ccbed4c021e7.tar.gz qemu-ecca5ca549c13202504aacaf2885ccbed4c021e7.tar.bz2 | |
hw/i386/pc: Have pc_init_isa() pass a NULL pci_type argument
The "isapc" machine only provides an ISA bus, not a PCI one,
and doesn't instanciate any i440FX south bridge.
Its machine class defines PCMachineClass::pci_enabled = false,
and pc_init1() only uses the pci_type argument when pci_enabled
is true. Since for this machine the argument is not used,
passing NULL makes more sense.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Bernhard Beschow <shentey@gmail.com>
Message-Id: <20240301185936.95175-5-philmd@linaro.org>
| -rw-r--r-- | hw/i386/pc_piix.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index e14dce9..319bc4b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -450,7 +450,7 @@ static void pc_compat_2_0_fn(MachineState *machine) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { - pc_init1(machine, TYPE_I440FX_PCI_DEVICE); + pc_init1(machine, NULL); } #endif |