diff options
| author | Kashyap Chamarthy <kchamart@redhat.com> | 2020-08-05 12:01:58 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-09-03 09:41:36 +0200 |
| commit | e947e9c8012b779dff6039fbe738a5584db6431d (patch) | |
| tree | 8030f08fa3cd1f96f9b05ee95fe2c15f1f9bf9f3 | |
| parent | 221db5daf6b3666f1c8e4ca06ae45892e99a112f (diff) | |
| download | qemu-e947e9c8012b779dff6039fbe738a5584db6431d.zip qemu-e947e9c8012b779dff6039fbe738a5584db6431d.tar.gz qemu-e947e9c8012b779dff6039fbe738a5584db6431d.tar.bz2 | |
qapi/block-core.json: Remove stale description of 'blockdev-add'
On a 'qemu-discuss' thread[1], Kevin identifies that the current doc
blurb for @blockdev-add is stale:
This is actually a documentation bug. @id doesn't exist,
blockdev-add never creates a BlockBackend. This was different in the
very first versions of the patches to add blockdev-add and we
probably just forgot to update the documentation after removing it.
So remove the stale bits.
And the requirement for 'node-name' is already mentioned in the
documentation of @BlockdevOptions:
[...]
# @node-name: the node name of the new node (Since 2.0).
# This option is required on the top level of blockdev-add.
# Valid node names start with an alphabetic character and may
# contain only alphanumeric characters, '-', '.' and '_'. Their
# maximum length is 31 characters.
[...]
[1] https://lists.nongnu.org/archive/html/qemu-discuss/2020-07/msg00071.html
-- equivalent to "-drive if=ide,id=disk0....."
Fixes: be4b67bc7d ("blockdev: Allow creation of BDS trees without BB")
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Suggested-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200805100158.1239390-1-kchamart@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
| -rw-r--r-- | qapi/block-core.json | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/qapi/block-core.json b/qapi/block-core.json index db08c58..55b58ba 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -4036,9 +4036,7 @@ ## # @blockdev-add: # -# Creates a new block device. If the @id option is given at the top level, a -# BlockBackend will be created; otherwise, @node-name is mandatory at the top -# level and no BlockBackend will be created. +# Creates a new block device. # # Since: 2.9 # |