diff options
| author | Bernhard Beschow <shentey@gmail.com> | 2024-02-13 16:49:58 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-02-15 15:53:12 +0100 |
| commit | e6f2193367a6b060b65c8898c02d0502f8aaa7e5 (patch) | |
| tree | 1040e013776abde60f9a0811bb8f1633f23ecf11 | |
| parent | 5939fc749102c5bc0b6e87571ceba93610b2099c (diff) | |
| download | qemu-e6f2193367a6b060b65c8898c02d0502f8aaa7e5.zip qemu-e6f2193367a6b060b65c8898c02d0502f8aaa7e5.tar.gz qemu-e6f2193367a6b060b65c8898c02d0502f8aaa7e5.tar.bz2 | |
hw/mips/Kconfig: Remove ISA dependencies from MIPSsim board
The board doesn't have a working ISA bus, only some I/O space.
Selecting ISA_BUS and including hw/isa/isa.h is not necessary.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Message-ID: <20230109204124.102592-3-shentey@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240213155005.109954-4-pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| -rw-r--r-- | hw/mips/Kconfig | 3 | ||||
| -rw-r--r-- | hw/mips/mipssim.c | 7 |
2 files changed, 6 insertions, 4 deletions
diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig index ab61af2..afcfb2b 100644 --- a/hw/mips/Kconfig +++ b/hw/mips/Kconfig @@ -6,8 +6,7 @@ config MALTA config MIPSSIM bool - select ISA_BUS - select SERIAL_ISA + select SERIAL select MIPSNET config JAZZ diff --git a/hw/mips/mipssim.c b/hw/mips/mipssim.c index 16af316..a12427b 100644 --- a/hw/mips/mipssim.c +++ b/hw/mips/mipssim.c @@ -31,7 +31,6 @@ #include "hw/clock.h" #include "hw/mips/mips.h" #include "hw/char/serial.h" -#include "hw/isa/isa.h" #include "net/net.h" #include "sysemu/sysemu.h" #include "hw/boards.h" @@ -206,7 +205,11 @@ mips_mipssim_init(MachineState *machine) cpu_mips_irq_init_cpu(cpu); cpu_mips_clock_init(cpu); - /* Register 64 KB of ISA IO space at 0x1fd00000. */ + /* + * Register 64 KB of ISA IO space at 0x1fd00000. But without interrupts + * (except for the hardcoded serial port interrupt) -device cannot work, + * so do not expose the ISA bus to the user. + */ memory_region_init_alias(isa, NULL, "isa_mmio", get_system_io(), 0, 0x00010000); memory_region_add_subregion(get_system_memory(), 0x1fd00000, isa); |