diff options
| author | Masato Imai <mii@sfc.wide.ad.jp> | 2024-06-17 22:46:04 +0800 |
|---|---|---|
| committer | Hyman Huang <yong.huang@smartx.com> | 2024-06-17 23:29:21 +0800 |
| commit | e65152d5483b2c847ec7a947ed52650152cfdcc0 (patch) | |
| tree | 9285136b078b257ec32769c9df0e66774354066b | |
| parent | 05ad1440b8428b0ade9b8e5c01469adb8fbf83e3 (diff) | |
| download | qemu-e65152d5483b2c847ec7a947ed52650152cfdcc0.zip qemu-e65152d5483b2c847ec7a947ed52650152cfdcc0.tar.gz qemu-e65152d5483b2c847ec7a947ed52650152cfdcc0.tar.bz2 | |
migration/dirtyrate: Fix segmentation fault
Since the kvm_dirty_ring_enabled function accesses a null kvm_state
pointer when the KVM acceleration parameter is not specified, running
calc_dirty_rate with the -r or -b option causes a segmentation fault.
Signed-off-by: Masato Imai <mii@sfc.wide.ad.jp>
Message-ID: <20240507025010.1968881-1-mii@sfc.wide.ad.jp>
[Assert kvm_state when kvm_dirty_ring_enabled was called to fix it. - Hyman]
Signed-off-by: Hyman Huang <yong.huang@smartx.com>
| -rw-r--r-- | accel/kvm/kvm-all.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 009b49d..854cb86 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2329,7 +2329,7 @@ bool kvm_vcpu_id_is_valid(int vcpu_id) bool kvm_dirty_ring_enabled(void) { - return kvm_state->kvm_dirty_ring_size ? true : false; + return kvm_state && kvm_state->kvm_dirty_ring_size; } static void query_stats_cb(StatsResultList **result, StatsTarget target, |