aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2025-02-25 08:06:50 +0100
committerEric Blake <eblake@redhat.com>2025-03-04 16:43:21 -0600
commite2668ba1ed44ad56f2f1653ff5f53b277d534fac (patch)
tree653434dc863bd96386c7591d138c90c3a19a1487
parentd0f439ddd37e1354daca3234976295189985cb04 (diff)
downloadqemu-e2668ba1ed44ad56f2f1653ff5f53b277d534fac.zip
qemu-e2668ba1ed44ad56f2f1653ff5f53b277d534fac.tar.gz
qemu-e2668ba1ed44ad56f2f1653ff5f53b277d534fac.tar.bz2
iotests: Stop NBD server in test 162 before starting the next one
Test 162 recently started failing for me for no obvious reasons (I did not spot any suspicious commits in this area), but looking in the 162.out.bad log file, there was a suspicious message at the end: qemu-nbd: Cannot lock pid file: Resource temporarily unavailable And indeed, the test starts the NBD server two times, without stopping the first server before running the second one, so the second one can indeed fail to lock the PID file. Thus let's make sure to stop the first server before the test continues with the second one. With this change, the test works fine for me again. Signed-off-by: Thomas Huth <thuth@redhat.com> Message-ID: <20250225070650.387638-1-thuth@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Eric Blake <eblake@redhat.com>
-rwxr-xr-xtests/qemu-iotests/1621
1 files changed, 1 insertions, 0 deletions
diff --git a/tests/qemu-iotests/162 b/tests/qemu-iotests/162
index 94dae60..956c2c5 100755
--- a/tests/qemu-iotests/162
+++ b/tests/qemu-iotests/162
@@ -65,6 +65,7 @@ done
$QEMU_IMG info "json:{'driver': 'nbd', 'host': 'localhost', 'port': $port}" \
| grep '^image' | sed -e "s/$port/PORT/"
+_stop_nbd_server
# This is a test for NBD's bdrv_refresh_filename() implementation: It expects
# either host or path to be set, but it must not assume that they are set to