aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZhao Liu <zhao1.liu@intel.com>2023-05-29 20:43:31 +0800
committerPhilippe Mathieu-Daudé <philmd@linaro.org>2023-06-28 14:27:59 +0200
commitdb5a06b3a21239ffa9424f89f98ee9afa14e955b (patch)
treedd43c385a90ebe38fabbb7a1712f8fa3257eed37
parent9638cbde6c4f433b157672c0fdee783c10be45fe (diff)
downloadqemu-db5a06b3a21239ffa9424f89f98ee9afa14e955b.zip
qemu-db5a06b3a21239ffa9424f89f98ee9afa14e955b.tar.gz
qemu-db5a06b3a21239ffa9424f89f98ee9afa14e955b.tar.bz2
target/i386/WHPX: Fix error message when fail to set ProcessorCount
003f230e37d7 ("machine: Tweak the order of topology members in struct CpuTopology") changes the meaning of MachineState.smp.cores from "the number of cores in one package" to "the number of cores in one die" and doesn't fix other uses of MachineState.smp.cores. And because of the introduction of cluster, now smp.cores just means "the number of cores in one cluster". This clearly does not fit the semantics here. And before this error message, WHvSetPartitionProperty() is called to set prop.ProcessorCount. So the error message should show the prop.ProcessorCount other than "cores per cluster" or "cores per package". Cc: Sunil Muthuswamy <sunilmut@microsoft.com> Signed-off-by: Zhao Liu <zhao1.liu@intel.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230529124331.412822-1-zhao1.liu@linux.intel.com> [PMD: Use '%u' format for ProcessorCount] Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
-rw-r--r--target/i386/whpx/whpx-all.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c
index 9ee04ee..57580ca 100644
--- a/target/i386/whpx/whpx-all.c
+++ b/target/i386/whpx/whpx-all.c
@@ -2598,8 +2598,8 @@ static int whpx_accel_init(MachineState *ms)
sizeof(WHV_PARTITION_PROPERTY));
if (FAILED(hr)) {
- error_report("WHPX: Failed to set partition core count to %d,"
- " hr=%08lx", ms->smp.cores, hr);
+ error_report("WHPX: Failed to set partition processor count to %u,"
+ " hr=%08lx", prop.ProcessorCount, hr);
ret = -EINVAL;
goto error;
}