aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2024-01-29 19:27:12 -0500
committerStefan Hajnoczi <stefanha@redhat.com>2024-01-30 16:17:59 -0500
commitd5eaeefbdac30d9ca62612f18e2d3f4509272856 (patch)
treef17eaa64bf0d30544048642fbf9650e21f387783
parent615eaeab3d318ba239d54141a4251746782f65c1 (diff)
downloadqemu-d5eaeefbdac30d9ca62612f18e2d3f4509272856.zip
qemu-d5eaeefbdac30d9ca62612f18e2d3f4509272856.tar.gz
qemu-d5eaeefbdac30d9ca62612f18e2d3f4509272856.tar.bz2
pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()
The following expression is incorrect because blk_pread_nonzeroes() deals in units of bytes, not sectors: bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS) ^^^^^^^ BDRV_REQUEST_MAX_BYTES is the appropriate constant. Fixes: a4b15a8b9ef2 ("pflash: Only read non-zero parts of backend image") Cc: Xiang Zheng <zhengxiang9@huawei.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-id: 20240130002712.257815-1-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
-rw-r--r--hw/block/block.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/block/block.c b/hw/block/block.c
index 9f52ee6..ff50300 100644
--- a/hw/block/block.c
+++ b/hw/block/block.c
@@ -30,7 +30,7 @@ static int blk_pread_nonzeroes(BlockBackend *blk, hwaddr size, void *buf)
BlockDriverState *bs = blk_bs(blk);
for (;;) {
- bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS);
+ bytes = MIN(size - offset, BDRV_REQUEST_MAX_BYTES);
if (bytes <= 0) {
return 0;
}