diff options
| author | Volker Rümelin <vr_qemu@t-online.de> | 2025-05-15 07:44:26 +0200 |
|---|---|---|
| committer | Marc-André Lureau <marcandre.lureau@redhat.com> | 2025-05-25 11:28:28 +0200 |
| commit | d009f26a54f573468be721590a19350c224bc730 (patch) | |
| tree | 1036d8d3a81931e338eee4d253d715054a25fa71 | |
| parent | ccb4fec0e5f233cb61a83b3af59ae11716ea06c0 (diff) | |
| download | qemu-d009f26a54f573468be721590a19350c224bc730.zip qemu-d009f26a54f573468be721590a19350c224bc730.tar.gz qemu-d009f26a54f573468be721590a19350c224bc730.tar.bz2 | |
hw/audio/asc: fix SIGSEGV in asc_realize()
AUD_open_out() may fail and return NULL. This may then lead to
a segmentation fault in memset() below. The memset() behaviour
is undefined if the pointer to the destination object is a null
pointer.
Add the missing error handling code.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Message-Id: <20250515054429.7385-4-vr_qemu@t-online.de>
| -rw-r--r-- | hw/audio/asc.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/hw/audio/asc.c b/hw/audio/asc.c index 18382cc..6721c0d 100644 --- a/hw/audio/asc.c +++ b/hw/audio/asc.c @@ -12,6 +12,7 @@ #include "qemu/osdep.h" #include "qemu/timer.h" +#include "qapi/error.h" #include "hw/sysbus.h" #include "hw/irq.h" #include "audio/audio.h" @@ -653,6 +654,12 @@ static void asc_realize(DeviceState *dev, Error **errp) s->voice = AUD_open_out(&s->card, s->voice, "asc.out", s, asc_out_cb, &as); + if (!s->voice) { + AUD_remove_card(&s->card); + error_setg(errp, "Initializing audio stream failed"); + return; + } + s->shift = 1; s->samples = AUD_get_buffer_size_out(s->voice) >> s->shift; s->mixbuf = g_malloc0(s->samples << s->shift); |