aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2022-03-03 20:23:41 +0000
committerPeter Maydell <peter.maydell@linaro.org>2022-03-07 13:16:50 +0000
commitcf734c2a0f6a61dd22639416a5295d0e0fd8a7cd (patch)
tree257db78a9c95c27b94f0383287c0fb289fa9ed3c
parentb45f91e1a70e70f482ed75b50e24850591db2e5e (diff)
downloadqemu-cf734c2a0f6a61dd22639416a5295d0e0fd8a7cd.zip
qemu-cf734c2a0f6a61dd22639416a5295d0e0fd8a7cd.tar.gz
qemu-cf734c2a0f6a61dd22639416a5295d0e0fd8a7cd.tar.bz2
hw/intc/arm_gicv3_cpuif: Fix register names in ICV_HPPIR read trace event
The trace_gicv3_icv_hppir_read trace event takes an integer value which it uses to form the register name, which should be either ICV_HPPIR0 or ICV_HPPIR1. We were passing in the 'grp' variable for this, but that is either GICV3_G0 or GICV3_G1NS, which happen to be 0 and 2, which meant that tracing for the ICV_HPPIR1 register was incorrectly printed as ICV_HPPIR2. Use the same approach we do for all the other similar trace events, and pass in 'ri->crm == 8 ? 0 : 1', deriving the index value directly from the ARMCPRegInfo struct. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20220303202341.2232284-6-peter.maydell@linaro.org
-rw-r--r--hw/intc/arm_gicv3_cpuif.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c
index d7e03d0..1a3d440 100644
--- a/hw/intc/arm_gicv3_cpuif.c
+++ b/hw/intc/arm_gicv3_cpuif.c
@@ -612,7 +612,8 @@ static uint64_t icv_hppir_read(CPUARMState *env, const ARMCPRegInfo *ri)
}
}
- trace_gicv3_icv_hppir_read(grp, gicv3_redist_affid(cs), value);
+ trace_gicv3_icv_hppir_read(ri->crm == 8 ? 0 : 1,
+ gicv3_redist_affid(cs), value);
return value;
}