diff options
| author | Chen Qun <kuhn.chenqun@huawei.com> | 2020-08-27 19:03:10 +0800 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2020-09-01 12:05:21 +0200 |
| commit | cad2197ba10f5634b87ded155ad85e060f6926eb (patch) | |
| tree | a095bf8d6150d8c8ab9791a04424daeb0f3a98ce | |
| parent | 4b602b6003140afc981d70c9cd721fc96425dd90 (diff) | |
| download | qemu-cad2197ba10f5634b87ded155ad85e060f6926eb.zip qemu-cad2197ba10f5634b87ded155ad85e060f6926eb.tar.gz qemu-cad2197ba10f5634b87ded155ad85e060f6926eb.tar.bz2 | |
hw/intc: fix default registers value in exynos4210_combiner_read()
Clang static code analyzer show warning:
hw/intc/exynos4210_combiner.c:231:9: warning: Value stored to 'val' is never read
val = s->reg_set[offset >> 2];
The default register return value should be return 'val'.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20200827110311.164316-10-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
| -rw-r--r-- | hw/intc/exynos4210_combiner.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index b8561e4..59dd27f 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -229,7 +229,6 @@ exynos4210_combiner_read(void *opaque, hwaddr offset, unsigned size) TARGET_FMT_plx "offset\n", offset); } val = s->reg_set[offset >> 2]; - return 0; } return val; } |