diff options
| author | Clément Chigot <chigot@adacore.com> | 2024-03-08 16:27:19 +0100 |
|---|---|---|
| committer | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-03-09 19:17:01 +0100 |
| commit | c9ee67c3c64cb161a092d9af6be0c17643d92be2 (patch) | |
| tree | 921ba3b3881b9153cee2610511f830ad0bd06d40 | |
| parent | 78abf93cc7e2254401ccdb4df53e608927d81feb (diff) | |
| download | qemu-c9ee67c3c64cb161a092d9af6be0c17643d92be2.zip qemu-c9ee67c3c64cb161a092d9af6be0c17643d92be2.tar.gz qemu-c9ee67c3c64cb161a092d9af6be0c17643d92be2.tar.bz2 | |
hw/intc/grlib_irqmp: abort realize when ncpus value is out of range
Even if the error is set, the build is not aborted when the ncpus value
is wrong, the return is missing.
Signed-off-by: Clément Chigot <chigot@adacore.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: 6bf1478543 ("hw/intc/grlib_irqmp: add ncpus property")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240308152719.591232-1-chigot@adacore.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
| -rw-r--r-- | hw/intc/grlib_irqmp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/intc/grlib_irqmp.c b/hw/intc/grlib_irqmp.c index 144b121..c6c51a3 100644 --- a/hw/intc/grlib_irqmp.c +++ b/hw/intc/grlib_irqmp.c @@ -356,6 +356,7 @@ static void grlib_irqmp_realize(DeviceState *dev, Error **errp) error_setg(errp, "Invalid ncpus properties: " "%u, must be 0 < ncpus =< %u.", irqmp->ncpus, IRQMP_MAX_CPU); + return; } qdev_init_gpio_in(dev, grlib_irqmp_set_irq, MAX_PILS); |