diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2023-02-28 19:06:32 +0000 |
|---|---|---|
| committer | Alex Bennée <alex.bennee@linaro.org> | 2023-03-01 10:31:20 +0000 |
| commit | c997068077fbeabb8b3810bdf1592e5a0d7548c3 (patch) | |
| tree | e88bf1c705a50a150a03385d9eb1987ef4a46140 | |
| parent | ab4c1361090f8a7f408a72de4dcbb7a5b9134300 (diff) | |
| download | qemu-c997068077fbeabb8b3810bdf1592e5a0d7548c3.zip qemu-c997068077fbeabb8b3810bdf1592e5a0d7548c3.tar.gz qemu-c997068077fbeabb8b3810bdf1592e5a0d7548c3.tar.bz2 | |
tests: be a bit more strict cleaning up fifos
When we re-factored we dropped the unlink() step which turns out to be
required for rmdir to do its thing. If we had been checking the return
value we would have noticed so lets do that with this fix.
Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230228190653.1602033-4-alex.bennee@linaro.org>
| -rw-r--r-- | tests/unit/test-io-channel-command.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tests/unit/test-io-channel-command.c b/tests/unit/test-io-channel-command.c index 04b75ab..c6e66a8 100644 --- a/tests/unit/test-io-channel-command.c +++ b/tests/unit/test-io-channel-command.c @@ -42,6 +42,7 @@ static void test_io_channel_command_fifo(bool async) g_auto(GStrv) dstargv = g_strsplit(dstargs, " ", -1); QIOChannel *src, *dst; QIOChannelTest *test; + int err; if (mkfifo(fifo, 0600)) { g_error("mkfifo: %s", strerror(errno)); @@ -61,7 +62,10 @@ static void test_io_channel_command_fifo(bool async) object_unref(OBJECT(src)); object_unref(OBJECT(dst)); - g_rmdir(tmpdir); + err = g_unlink(fifo); + g_assert(err == 0); + err = g_rmdir(tmpdir); + g_assert(err == 0); } static void test_io_channel_command_fifo_async(void) |