aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Auger <eric.auger@redhat.com>2023-11-09 18:07:15 +0100
committerMichael S. Tsirkin <mst@redhat.com>2023-12-02 15:56:49 -0500
commitc8559fcb1559b472e7ec79b990f5206249b2ba69 (patch)
treea4a3f6b9611ff64cadb14bc6a99fe38c31fbf888
parentc04cfb4596ad5032a9869a8f77fe9114ca8af9e0 (diff)
downloadqemu-c8559fcb1559b472e7ec79b990f5206249b2ba69.zip
qemu-c8559fcb1559b472e7ec79b990f5206249b2ba69.tar.gz
qemu-c8559fcb1559b472e7ec79b990f5206249b2ba69.tar.bz2
virtio-iommu: Remove useless !sdev check in virtio_iommu_probe()
The code already checks iommu_mr is not NULL so there is no need to check container_of() is not NULL. Remove the check. Fixes: CID 1523901 Fixes: 09b4c3d6a2 ("virtio-iommu: Record whether a probe request has been issued") Signed-off-by: Eric Auger <eric.auger@redhat.com> Reported-by: Coverity (CID 1523901) Message-Id: <20231109170715.259520-1-eric.auger@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/virtio/virtio-iommu.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/hw/virtio/virtio-iommu.c b/hw/virtio/virtio-iommu.c
index 89fb576..9d463ef 100644
--- a/hw/virtio/virtio-iommu.c
+++ b/hw/virtio/virtio-iommu.c
@@ -698,9 +698,6 @@ static int virtio_iommu_probe(VirtIOIOMMU *s,
}
sdev = container_of(iommu_mr, IOMMUDevice, iommu_mr);
- if (!sdev) {
- return -EINVAL;
- }
count = virtio_iommu_fill_resv_mem_prop(sdev, ep_id, buf, free);
if (count < 0) {