diff options
| author | Pankaj Raghav <p.raghav@samsung.com> | 2021-09-15 17:43:30 +0200 |
|---|---|---|
| committer | Klaus Jensen <k.jensen@samsung.com> | 2021-09-24 08:43:58 +0200 |
| commit | c53a9a91021c2f57de9ab18393d0048bd0fe90c2 (patch) | |
| tree | 5bc5af87807ca9486f0f3d4f5f86541ac78dea32 | |
| parent | 07a3dfa7c41a94788881b649518507610c727994 (diff) | |
| download | qemu-c53a9a91021c2f57de9ab18393d0048bd0fe90c2.zip qemu-c53a9a91021c2f57de9ab18393d0048bd0fe90c2.tar.gz qemu-c53a9a91021c2f57de9ab18393d0048bd0fe90c2.tar.bz2 | |
hw/nvme: Return error for fused operations
Currently, FUSED operations are not supported by QEMU. As per the 1.4 SPEC,
controller should abort the command that requested a fused operation with
an INVALID FIELD error code if they are not supported.
Changes from v1:
Added FUSE flag check also to the admin cmd processing as the FUSED
operations are mentioned in the general SQE section in the SPEC.
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
| -rw-r--r-- | hw/nvme/ctrl.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index dc0e7b0..2f247a9 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -3893,6 +3893,10 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) return ns->status; } + if (NVME_CMD_FLAGS_FUSE(req->cmd.flags)) { + return NVME_INVALID_FIELD; + } + req->ns = ns; switch (req->cmd.opcode) { @@ -5475,6 +5479,10 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) return NVME_INVALID_FIELD | NVME_DNR; } + if (NVME_CMD_FLAGS_FUSE(req->cmd.flags)) { + return NVME_INVALID_FIELD; + } + switch (req->cmd.opcode) { case NVME_ADM_CMD_DELETE_SQ: return nvme_del_sq(n, req); |