diff options
author | Thomas Huth <thuth@redhat.com> | 2018-08-02 11:49:36 +0200 |
---|---|---|
committer | Juan Quintela <quintela@redhat.com> | 2018-08-22 12:15:33 +0200 |
commit | c50055ae7c0684edc6f939579f95ea290363b58f (patch) | |
tree | e9322d16e7aca259fa1bd2aea4248be7d8547464 | |
parent | 54db882f073a015ba3e198e7e57eb91b1e72e63d (diff) | |
download | qemu-c50055ae7c0684edc6f939579f95ea290363b58f.zip qemu-c50055ae7c0684edc6f939579f95ea290363b58f.tar.gz qemu-c50055ae7c0684edc6f939579f95ea290363b58f.tar.bz2 |
tests/migration-test: Silence the kvm_hv message by default
When running "make check" on a non-POWER host, there is currently an ugly
line in the output like this:
[...]
GTESTER check-qtest-nios2
GTESTER check-qtest-or1k
GTESTER check-qtest-ppc64
Skipping test: kvm_hv not available Skipping test: kvm_hv not available Skipping test: kvm_hv not available Skipping test: kvm_hv not available GTESTER check-qtest-ppcemb
GTESTER check-qtest-ppc
GTESTER check-qtest-riscv32
GTESTER check-qtest-riscv64
[...]
Move the check to the beginning of the main function instead, so that
we do not have to test the condition again and again for each test,
and better use g_test_message() instead of g_print() here, like it is
also done in ufd_version_check() already.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
-rw-r--r-- | tests/migration-test.c | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/tests/migration-test.c b/tests/migration-test.c index eb58d0a..0e687b7 100644 --- a/tests/migration-test.c +++ b/tests/migration-test.c @@ -438,15 +438,6 @@ static int test_migrate_start(QTestState **from, QTestState **to, " -incoming %s", accel, tmpfs, bootpath, uri); } else if (strcmp(arch, "ppc64") == 0) { - - /* On ppc64, the test only works with kvm-hv, but not with kvm-pr - * and TCG is touchy due to race conditions on dirty bits - * (especially on PPC for some reason) - */ - if (access("/sys/module/kvm_hv", F_OK)) { - g_print("Skipping test: kvm_hv not available "); - return -1; - } cmd_src = g_strdup_printf("-machine accel=%s -m 256M" " -name source,debug-threads=on" " -serial file:%s/src_serial" @@ -750,6 +741,17 @@ int main(int argc, char **argv) return 0; } + /* + * On ppc64, the test only works with kvm-hv, but not with kvm-pr and TCG + * is touchy due to race conditions on dirty bits (especially on PPC for + * some reason) + */ + if (g_str_equal(qtest_get_arch(), "ppc64") && + access("/sys/module/kvm_hv", F_OK)) { + g_test_message("Skipping test: kvm_hv not available"); + return 0; + } + tmpfs = mkdtemp(template); if (!tmpfs) { g_test_message("mkdtemp on path (%s): %s\n", template, strerror(errno)); |