diff options
| author | Greg Kurz <groug@kaod.org> | 2016-07-13 12:00:17 +0200 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2016-07-18 10:40:27 +1000 |
| commit | c4dfc14b5573d7a2c9731dd3d0cfc20f331f3c87 (patch) | |
| tree | 3e8f83bc9f301ee663816abe1f5a052dc6efea7b | |
| parent | 5cbc64de25973e9129c5a7897734a06ac64b9aff (diff) | |
| download | qemu-c4dfc14b5573d7a2c9731dd3d0cfc20f331f3c87.zip qemu-c4dfc14b5573d7a2c9731dd3d0cfc20f331f3c87.tar.gz qemu-c4dfc14b5573d7a2c9731dd3d0cfc20f331f3c87.tar.bz2 | |
ppc: abort if compat property contains an unknown value
It is not possible to set the compat property to an unknown value with
powerpc_set_compat(). Something must have gone terribly wrong in QEMU,
if we detect an "Internal error" in powerpc_get_compat(). Let's abort then.
This patch also drops the "max_compat ? *max_compat : -1" construct. It is
useless since max_compat is dereferenced a few lines above.
Signed-off-by: Greg Kurz <groug@kaod.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | target-ppc/translate_init.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 7cb7842..5ecafc7 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -8446,8 +8446,8 @@ static void powerpc_get_compat(Object *obj, Visitor *v, const char *name, case 0: break; default: - error_setg(errp, "Internal error: compat is set to %x", - max_compat ? *max_compat : -1); + error_report("Internal error: compat is set to %x", *max_compat); + abort(); break; } |