aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKlaus Jensen <k.jensen@samsung.com>2022-04-29 10:33:34 +0200
committerKlaus Jensen <k.jensen@samsung.com>2022-06-03 21:48:24 +0200
commitbd9f371c6f6eeb8e907dfc770876ad8ef4ff85fc (patch)
tree801bf3a4ba29cbb971d48c7009ecd136407b313c
parent36d83272d5e45dff13e988ee0a59f11c58b442ba (diff)
downloadqemu-bd9f371c6f6eeb8e907dfc770876ad8ef4ff85fc.zip
qemu-bd9f371c6f6eeb8e907dfc770876ad8ef4ff85fc.tar.gz
qemu-bd9f371c6f6eeb8e907dfc770876ad8ef4ff85fc.tar.bz2
hw/nvme: do not auto-generate uuid
Do not default to generate an UUID for namespaces if it is not explicitly specified. This is a technically a breaking change in behavior. However, since the UUID changes on every VM launch, it is not spec compliant and is of little use since the UUID cannot be used reliably anyway and the behavior prior to this patch must be considered buggy. Reviewed-by: Keith Busch <kbusch@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
-rw-r--r--hw/nvme/ns.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/hw/nvme/ns.c b/hw/nvme/ns.c
index 06a0413..1b9c9d1 100644
--- a/hw/nvme/ns.c
+++ b/hw/nvme/ns.c
@@ -614,7 +614,7 @@ static Property nvme_ns_props[] = {
DEFINE_PROP_BOOL("detached", NvmeNamespace, params.detached, false),
DEFINE_PROP_BOOL("shared", NvmeNamespace, params.shared, true),
DEFINE_PROP_UINT32("nsid", NvmeNamespace, params.nsid, 0),
- DEFINE_PROP_UUID("uuid", NvmeNamespace, params.uuid),
+ DEFINE_PROP_UUID_NODEFAULT("uuid", NvmeNamespace, params.uuid),
DEFINE_PROP_UINT64("eui64", NvmeNamespace, params.eui64, 0),
DEFINE_PROP_UINT16("ms", NvmeNamespace, params.ms, 0),
DEFINE_PROP_UINT8("mset", NvmeNamespace, params.mset, 0),