diff options
| author | Zheng Huang <hz1624917200@gmail.com> | 2025-05-09 19:21:35 +0800 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2025-05-12 17:48:32 +0200 |
| commit | bbdbc47b5c6907e065f84e751d127dae3cebfd54 (patch) | |
| tree | 87f79cb111514b0534bf729d5fc1c4e683d1dfb8 | |
| parent | 428c0acd953a626dab55e2c07401ce99c2271119 (diff) | |
| download | qemu-bbdbc47b5c6907e065f84e751d127dae3cebfd54.zip qemu-bbdbc47b5c6907e065f84e751d127dae3cebfd54.tar.gz qemu-bbdbc47b5c6907e065f84e751d127dae3cebfd54.tar.bz2 | |
hw/audio/cs4231a: fix assertion error in isa_bus_get_irq
This patch fixes an assertion error in isa_bus_get_irq() in
/hw/isa/isa-bus.c by adding a constraint to the irq property.
Patch v1 misused ISA_NUM_IRQS, pls ignore that.
Signed-off-by: Zheng Huang <hz1624917200@gmail.com>
Link: https://lore.kernel.org/r/6d228069-e38f-4c46-813f-edcccc5c47e4@gmail.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| -rw-r--r-- | hw/audio/cs4231a.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index 06b44da..eb9a458 100644 --- a/hw/audio/cs4231a.c +++ b/hw/audio/cs4231a.c @@ -682,6 +682,10 @@ static void cs4231a_realizefn (DeviceState *dev, Error **errp) return; } + if (s->irq >= ISA_NUM_IRQS) { + error_setg(errp, "Invalid IRQ %d (max %d)", s->irq, ISA_NUM_IRQS - 1); + return; + } s->pic = isa_bus_get_irq(bus, s->irq); k = ISADMA_GET_CLASS(s->isa_dma); k->register_channel(s->isa_dma, s->dma, cs_dma_read, s); |