diff options
| author | Stefan Hajnoczi <stefanha@redhat.com> | 2023-12-05 13:20:01 -0500 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-12-21 22:49:27 +0100 |
| commit | b5f4fda4fb773257e142429e4fe78bbdea771075 (patch) | |
| tree | 0f985780521e773fefc021a6bfff9cf5d5cb9a25 | |
| parent | b3496d129bf730524a52a958157b4e6c2d624e67 (diff) | |
| download | qemu-b5f4fda4fb773257e142429e4fe78bbdea771075.zip qemu-b5f4fda4fb773257e142429e4fe78bbdea771075.tar.gz qemu-b5f4fda4fb773257e142429e4fe78bbdea771075.tar.bz2 | |
aio: make aio_context_acquire()/aio_context_release() a no-op
aio_context_acquire()/aio_context_release() has been replaced by
fine-grained locking to protect state shared by multiple threads. The
AioContext lock still plays the role of balancing locking in
AIO_WAIT_WHILE() and many functions in QEMU either require that the
AioContext lock is held or not held for this reason. In other words, the
AioContext lock is purely there for consistency with itself and serves
no real purpose anymore.
Stop actually acquiring/releasing the lock in
aio_context_acquire()/aio_context_release() so that subsequent patches
can remove callers across the codebase incrementally.
I have performed "make check" and qemu-iotests stress tests across
x86-64, ppc64le, and aarch64 to confirm that there are no failures as a
result of eliminating the lock.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231205182011.1976568-5-stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | util/async.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/util/async.c b/util/async.c index 8f90ddc..04ee83d 100644 --- a/util/async.c +++ b/util/async.c @@ -725,12 +725,12 @@ void aio_context_unref(AioContext *ctx) void aio_context_acquire(AioContext *ctx) { - qemu_rec_mutex_lock(&ctx->lock); + /* TODO remove this function */ } void aio_context_release(AioContext *ctx) { - qemu_rec_mutex_unlock(&ctx->lock); + /* TODO remove this function */ } QEMU_DEFINE_STATIC_CO_TLS(AioContext *, my_aiocontext) |