diff options
| author | Markus Armbruster <armbru@redhat.com> | 2025-07-23 15:32:56 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2025-09-01 13:10:55 +0200 |
| commit | b2e4534a2c9ce3d20ba44d855f1e2b71cc53c3a3 (patch) | |
| tree | ff453b25ab874573fcc003ad5856b0fb1fc7bd4b | |
| parent | a12ff7f807e3ae2e254ac1de45c3892831479a0f (diff) | |
| download | qemu-b2e4534a2c9ce3d20ba44d855f1e2b71cc53c3a3.zip qemu-b2e4534a2c9ce3d20ba44d855f1e2b71cc53c3a3.tar.gz qemu-b2e4534a2c9ce3d20ba44d855f1e2b71cc53c3a3.tar.bz2 | |
i386/kvm/vmsr_energy: Plug memory leak on failure to connect socket
vmsr_open_socket() leaks the Error set by
qio_channel_socket_connect_sync(). Plug the leak by not creating the
Error.
Fixes: 0418f90809ae (Add support for RAPL MSRs in KVM/Qemu)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-ID: <20250723133257.1497640-2-armbru@redhat.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
| -rw-r--r-- | target/i386/kvm/vmsr_energy.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/target/i386/kvm/vmsr_energy.c b/target/i386/kvm/vmsr_energy.c index 58ce3df..890322a 100644 --- a/target/i386/kvm/vmsr_energy.c +++ b/target/i386/kvm/vmsr_energy.c @@ -57,13 +57,9 @@ QIOChannelSocket *vmsr_open_socket(const char *path) }; QIOChannelSocket *sioc = qio_channel_socket_new(); - Error *local_err = NULL; qio_channel_set_name(QIO_CHANNEL(sioc), "vmsr-helper"); - qio_channel_socket_connect_sync(sioc, - &saddr, - &local_err); - if (local_err) { + if (qio_channel_socket_connect_sync(sioc, &saddr, NULL) < 0) { /* Close socket. */ qio_channel_close(QIO_CHANNEL(sioc), NULL); object_unref(OBJECT(sioc)); |