diff options
author | Juan Quintela <quintela@redhat.com> | 2023-03-02 12:10:33 +0100 |
---|---|---|
committer | Juan Quintela <quintela@redhat.com> | 2023-04-27 16:37:28 +0200 |
commit | b1a8795654561b23eaf5bb134b61e5b23545046d (patch) | |
tree | 69b91545115cd79de973d8bb7d2ccdae4c9893e6 | |
parent | b7b73122dd12b5fea63347253b428a9af66303c2 (diff) | |
download | qemu-b1a8795654561b23eaf5bb134b61e5b23545046d.zip qemu-b1a8795654561b23eaf5bb134b61e5b23545046d.tar.gz qemu-b1a8795654561b23eaf5bb134b61e5b23545046d.tar.bz2 |
migration: Remove MigrationState from block_cleanup_parameters()
This makes the function more regular with everything else.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
-rw-r--r-- | migration/migration.c | 4 | ||||
-rw-r--r-- | migration/options.c | 4 | ||||
-rw-r--r-- | migration/options.h | 2 |
3 files changed, 6 insertions, 4 deletions
diff --git a/migration/migration.c b/migration/migration.c index cefe6da..ef8caa7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1218,7 +1218,7 @@ static void migrate_fd_cleanup(MigrationState *s) error_report_err(error_copy(s->error)); } notifier_list_notify(&migration_state_notifiers, s); - block_cleanup_parameters(s); + block_cleanup_parameters(); yank_unregister_instance(MIGRATION_YANK_INSTANCE); } @@ -1712,7 +1712,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk, "a valid migration protocol"); migrate_set_state(&s->state, MIGRATION_STATUS_SETUP, MIGRATION_STATUS_FAILED); - block_cleanup_parameters(s); + block_cleanup_parameters(); return; } diff --git a/migration/options.c b/migration/options.c index 82adbf3..da99c62 100644 --- a/migration/options.c +++ b/migration/options.c @@ -600,8 +600,10 @@ void migrate_set_block_incremental(bool value) /* parameters helpers */ -void block_cleanup_parameters(MigrationState *s) +void block_cleanup_parameters(void) { + MigrationState *s = migrate_get_current(); + if (s->must_remove_block_options) { /* setting to false can never fail */ migrate_cap_set(MIGRATION_CAPABILITY_BLOCK, false, &error_abort); diff --git a/migration/options.h b/migration/options.h index 1fc8d34..3948218 100644 --- a/migration/options.h +++ b/migration/options.h @@ -90,6 +90,6 @@ void migrate_set_block_incremental(bool value); bool migrate_params_check(MigrationParameters *params, Error **errp); void migrate_params_init(MigrationParameters *params); -void block_cleanup_parameters(MigrationState *s); +void block_cleanup_parameters(void); #endif |