diff options
| author | Alex Bennée <alex.bennee@linaro.org> | 2020-05-21 14:57:48 +0100 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2020-05-28 07:58:36 +0200 |
| commit | a932eec49d9ec106c7952314ad1adc28f0986076 (patch) | |
| tree | 6985ef826665ac2fa61bac7dc58663699790dcb5 | |
| parent | 06539ebc76b8625587aa78d646a9d8d5fddf84f3 (diff) | |
| download | qemu-a932eec49d9ec106c7952314ad1adc28f0986076.zip qemu-a932eec49d9ec106c7952314ad1adc28f0986076.tar.gz qemu-a932eec49d9ec106c7952314ad1adc28f0986076.tar.bz2 | |
linux-user: limit check to HOST_LONG_BITS < TARGET_ABI_BITS
Newer clangs rightly spot that you can never exceed the full address
space of 64 bit hosts with:
linux-user/elfload.c:2076:41: error: result of comparison 'unsigned
long' > 18446744073709551615 is always false
[-Werror,-Wtautological-type-limit-compare]
4685 if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) {
4686 ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~
4687 1 error generated.
So lets limit the check to 32 bit hosts only.
Fixes: ee94743034bf
Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200525131823.715-8-thuth@redhat.com>
[thuth: Use HOST_LONG_BITS < TARGET_ABI_BITS instead of HOST_LONG_BITS == 32]
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | linux-user/elfload.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 01a9323..ebc663e 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2073,12 +2073,14 @@ static void pgb_have_guest_base(const char *image_name, abi_ulong guest_loaddr, exit(EXIT_FAILURE); } } else { +#if HOST_LONG_BITS < TARGET_ABI_BITS if ((guest_hiaddr - guest_base) > ~(uintptr_t)0) { error_report("%s: requires more virtual address space " "than the host can provide (0x%" PRIx64 ")", image_name, (uint64_t)guest_hiaddr - guest_base); exit(EXIT_FAILURE); } +#endif } /* |