diff options
| author | Richard Henderson <richard.henderson@linaro.org> | 2024-05-01 22:44:08 -0700 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2024-05-29 12:41:15 +0200 |
| commit | a90e319569547ac7477606301b93491f3b886569 (patch) | |
| tree | 4f111ec041fd5797492dde6f9deefc6903c774f1 | |
| parent | 62613ca07382cb7a2d5f442d8a21e340c384a392 (diff) | |
| download | qemu-a90e319569547ac7477606301b93491f3b886569.zip qemu-a90e319569547ac7477606301b93491f3b886569.tar.gz qemu-a90e319569547ac7477606301b93491f3b886569.tar.bz2 | |
target/s390x: Disable conditional branch-to-next for PER
For PER, we require a conditional call to helper_per_branch
for the conditional branch. Fold the remaining optimization
into a call to helper_goto_direct, which will take care of
the remaining gbea adjustment.
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-ID: <20240502054417.234340-6-richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
| -rw-r--r-- | target/s390x/tcg/translate.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index de98115..0762094 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -1131,13 +1131,13 @@ static DisasJumpType help_branch(DisasContext *s, DisasCompare *c, goto egress; } if (is_imm) { - if (dest == s->pc_tmp) { - /* Branch to next. */ - per_branch(s, true); - ret = DISAS_NEXT; - goto egress; - } - if (c->cond == TCG_COND_ALWAYS) { + /* + * Do not optimize a conditional branch if PER enabled, because we + * still need a conditional call to helper_per_branch. + */ + if (c->cond == TCG_COND_ALWAYS + || (dest == s->pc_tmp && + !(s->base.tb->flags & FLAG_MASK_PER_BRANCH))) { ret = help_goto_direct(s, dest); goto egress; } |