aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>2017-07-26 23:42:20 -0300
committerMichael Tokarev <mjt@tls.msk.ru>2017-07-31 13:06:39 +0300
commita44af723b3d5e6fa003b9d7f70f249c5529aa03a (patch)
tree0b499d9472652c9f5a2da7051e5c3db21363d254
parentb929f7e56f505d18bea32b08b57a8b84c6b28f30 (diff)
downloadqemu-a44af723b3d5e6fa003b9d7f70f249c5529aa03a.zip
qemu-a44af723b3d5e6fa003b9d7f70f249c5529aa03a.tar.gz
qemu-a44af723b3d5e6fa003b9d7f70f249c5529aa03a.tar.bz2
thunk: assert nb_fields is valid
thunk.c:91:32: warning: Call to 'malloc' has an allocation size of 0 bytes se->field_offsets[i] = malloc(nb_fields * sizeof(int)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
-rw-r--r--thunk.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/thunk.c b/thunk.c
index 2dac366..d5d8645 100644
--- a/thunk.c
+++ b/thunk.c
@@ -67,7 +67,6 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
int nb_fields, offset, max_align, align, size, i, j;
assert(id < max_struct_entries);
- se = struct_entries + id;
/* first we count the number of fields */
type_ptr = types;
@@ -76,6 +75,8 @@ void thunk_register_struct(int id, const char *name, const argtype *types)
type_ptr = thunk_type_next(type_ptr);
nb_fields++;
}
+ assert(nb_fields > 0);
+ se = struct_entries + id;
se->field_types = types;
se->nb_fields = nb_fields;
se->name = name;