diff options
| author | Nicholas Piggin <npiggin@gmail.com> | 2025-01-18 03:22:40 +1000 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2025-02-20 18:23:19 -0500 |
| commit | 9e837c961a883392f8c4707a8d3d2e6c6aa793b6 (patch) | |
| tree | 296eecc21221683435ca2ec0484a1bdd77aa2865 | |
| parent | f9efcd47110de43dd841ada5bd1a40ec169eabca (diff) | |
| download | qemu-9e837c961a883392f8c4707a8d3d2e6c6aa793b6.zip qemu-9e837c961a883392f8c4707a8d3d2e6c6aa793b6.tar.gz qemu-9e837c961a883392f8c4707a8d3d2e6c6aa793b6.tar.bz2 | |
qtest/libqos/pci: Do not write to PBA memory
The PCI Local Bus Specification says the result of writes to MSI-X
PBA memory is undefined. QEMU implements them as no-ops, so remove
the pointless write from qpci_msix_pending().
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Message-Id: <20250117172244.406206-2-npiggin@gmail.com>
Reviewed-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
| -rw-r--r-- | tests/qtest/libqos/pci.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/tests/qtest/libqos/pci.c b/tests/qtest/libqos/pci.c index b23d723..a59197b 100644 --- a/tests/qtest/libqos/pci.c +++ b/tests/qtest/libqos/pci.c @@ -328,8 +328,6 @@ bool qpci_msix_pending(QPCIDevice *dev, uint16_t entry) g_assert(dev->msix_enabled); pba_entry = qpci_io_readl(dev, dev->msix_pba_bar, dev->msix_pba_off + off); - qpci_io_writel(dev, dev->msix_pba_bar, dev->msix_pba_off + off, - pba_entry & ~(1 << bit_n)); return (pba_entry & (1 << bit_n)) != 0; } |