diff options
| author | John Snow <jsnow@redhat.com> | 2021-10-19 10:49:04 -0400 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2021-11-01 11:54:59 -0400 |
| commit | 95a556e7c7ddeb8e9e370dd074f48ab77915aa82 (patch) | |
| tree | 4fd6359820630b2bd40df8969a151263e3b57d34 | |
| parent | af531756d25541a1b3b3d9a14e72e7fedd941a2e (diff) | |
| download | qemu-95a556e7c7ddeb8e9e370dd074f48ab77915aa82.zip qemu-95a556e7c7ddeb8e9e370dd074f48ab77915aa82.tar.gz qemu-95a556e7c7ddeb8e9e370dd074f48ab77915aa82.tar.bz2 | |
iotests/297: Move pylint config into pylintrc
Move --score=n and --notes=XXX,FIXME into pylintrc. This pulls
configuration out of code, which I think is probably a good thing in
general.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Hanna Reitz <hreitz@redhat.com>
Message-id: 20211019144918.3159078-2-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
| -rwxr-xr-x | tests/qemu-iotests/297 | 4 | ||||
| -rw-r--r-- | tests/qemu-iotests/pylintrc | 16 |
2 files changed, 17 insertions, 3 deletions
diff --git a/tests/qemu-iotests/297 b/tests/qemu-iotests/297 index 91ec34d..bc3a0ce 100755 --- a/tests/qemu-iotests/297 +++ b/tests/qemu-iotests/297 @@ -65,10 +65,8 @@ def run_linters(): print('=== pylint ===') sys.stdout.flush() - # Todo notes are fine, but fixme's or xxx's should probably just be - # fixed (in tests, at least) env = os.environ.copy() - subprocess.run(('pylint-3', '--score=n', '--notes=FIXME,XXX', *files), + subprocess.run(('pylint-3', *files), env=env, check=False) print('=== mypy ===') diff --git a/tests/qemu-iotests/pylintrc b/tests/qemu-iotests/pylintrc index 8cb4e1d..32ab77b 100644 --- a/tests/qemu-iotests/pylintrc +++ b/tests/qemu-iotests/pylintrc @@ -31,6 +31,22 @@ disable=invalid-name, too-many-statements, consider-using-f-string, + +[REPORTS] + +# Activate the evaluation score. +score=no + + +[MISCELLANEOUS] + +# List of note tags to take in consideration, separated by a comma. +# TODO notes are fine, but FIXMEs or XXXs should probably just be +# fixed (in tests, at least). +notes=FIXME, + XXX, + + [FORMAT] # Maximum number of characters on a single line. |