diff options
author | Pierrick Bouvier <pierrick.bouvier@linaro.org> | 2024-07-18 10:45:13 +0100 |
---|---|---|
committer | Alex Bennée <alex.bennee@linaro.org> | 2024-07-22 09:37:56 +0100 |
commit | 94ae227e15bd5ede18a92947412ef47c2b89e269 (patch) | |
tree | aca7104531e3816f6a326a1d8e2057d62f714707 | |
parent | 58fc249d9ebd7c6ed979cbf039ccfa93d1bae2b9 (diff) | |
download | qemu-94ae227e15bd5ede18a92947412ef47c2b89e269.zip qemu-94ae227e15bd5ede18a92947412ef47c2b89e269.tar.gz qemu-94ae227e15bd5ede18a92947412ef47c2b89e269.tar.bz2 |
plugins: fix mem callback array size
data was correctly copied, but size of array was not set
(g_array_sized_new only reserves memory, but does not set size).
As a result, callbacks were not called for code path relying on
plugin_register_vcpu_mem_cb().
Found when trying to trigger mem access callbacks for atomic
instructions.
Reviewed-by: Xingtao Yao <yaoxt.fnst@fujitsu.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20240706191335.878142-2-pierrick.bouvier@linaro.org>
Message-Id: <20240718094523.1198645-6-alex.bennee@linaro.org>
-rw-r--r-- | accel/tcg/plugin-gen.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index b6bae32..ec89a08 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -85,8 +85,7 @@ static void gen_enable_mem_helper(struct qemu_plugin_tb *ptb, len = insn->mem_cbs->len; arr = g_array_sized_new(false, false, sizeof(struct qemu_plugin_dyn_cb), len); - memcpy(arr->data, insn->mem_cbs->data, - len * sizeof(struct qemu_plugin_dyn_cb)); + g_array_append_vals(arr, insn->mem_cbs->data, len); qemu_plugin_add_dyn_cb_arr(arr); tcg_gen_st_ptr(tcg_constant_ptr((intptr_t)arr), tcg_env, |